Skip to content

ci: Remove node12 from testing matrix #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 1 addition & 53 deletions .github/workflows/integrate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,62 +114,10 @@ jobs:
- name: Unit tests
run: npm test

linuxNode12:
name: '[Linux] Node.js v12: Unit tests'
runs-on: ubuntu-latest
strategy:
matrix:
sls-version: [2, 3]
pipenv-version: ['2022.8.5', '2022.8.13']
steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Retrieve dependencies from cache
id: cacheNpm
uses: actions/cache@v2
with:
path: |
~/.npm
node_modules
key: npm-v12-${{ runner.os }}-${{ github.ref }}-${{ hashFiles('package.json') }}
restore-keys: npm-v12-${{ runner.os }}-${{ github.ref }}-

- name: Set up Python 3.7
uses: actions/setup-python@v2
with:
python-version: 3.7

- name: Install Node.js and npm
uses: actions/setup-node@v1
with:
node-version: 12.x

- name: Check python version
run: |
python --version

- name: Install setuptools
run: python -m pip install --force setuptools wheel

- name: Install pipenv / poetry
run: python -m pip install pipenv==${{ matrix.pipenv-version }} poetry

- name: Install serverless
run: npm install -g serverless@${{ matrix.sls-version }}

- name: Install dependencies
if: steps.cacheNpm.outputs.cache-hit != 'true'
run: |
npm update --no-save
npm update --save-dev --no-save
- name: Unit tests
run: npm test

tagIfNewVersion:
name: Tag if new version
runs-on: ubuntu-latest
needs: [windowsNode14, linuxNode14, linuxNode12]
needs: [windowsNode14, linuxNode14]
steps:
- name: Checkout repository
uses: actions/checkout@v2
Expand Down
54 changes: 0 additions & 54 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,57 +146,3 @@ jobs:
npm update --save-dev --no-save
- name: Unit tests
run: npm test

linuxNode12:
name: '[Linux] Node.js v12: Unit tests'
runs-on: ubuntu-latest
strategy:
matrix:
sls-version: [2, 3]
pipenv-version: ['2022.8.5', '2022.8.13', '2023.7.4', '2023.7.9']
steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Retrieve dependencies from cache
id: cacheNpm
uses: actions/cache@v2
with:
path: |
~/.npm
node_modules
key: npm-v12-${{ runner.os }}-${{ github.ref }}-${{ hashFiles('package.json') }}
restore-keys: |
npm-v12-${{ runner.os }}-${{ github.ref }}-
npm-v12-${{ runner.os }}-refs/heads/master-

- name: Set up Python 3.7
uses: actions/setup-python@v2
with:
python-version: 3.7

- name: Install Node.js and npm
uses: actions/setup-node@v1
with:
node-version: 12.x

- name: Check python version
run: |
python --version

- name: Install setuptools
run: python -m pip install --force setuptools wheel

- name: Install pipenv / poetry
run: python -m pip install pipenv==${{ matrix.pipenv-version }} poetry

- name: Install serverless
run: npm install -g serverless@${{ matrix.sls-version }}

- name: Install dependencies
if: steps.cacheNpm.outputs.cache-hit != 'true'
run: |
npm update --no-save
npm update --save-dev --no-save
- name: Unit tests
run: npm test