feat: Add architecture to requirements cache directory name #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mLupine 👋 Thanks a lot for PR proposal - could you rebase it on top of the current master? Also I see that linting CI step is failing, could you look into that? Thanks in advance! 🙇 |
added 2 commits
November 30, 2021 15:02
* master: (24 commits) chore: Remove Node16 tests chore: Remove dependabot chore: Reformat with eslint & prettier ci: Add commitlint job to CI ci: Introduce new CI publish workflow ci: Introduce integrate CI workflow ci: Update validate CI workflow refactor: Use `ServerlessError` in `pip` refactor: Use `ServerlessError` in `pipenv` refactor: Use `ServerlessError` in `poetry` refactor: Use `ServerlessError` in `docker` refactor: Cleanup and use `finally` for code simplification refactor: Ensure proper verbose progress logs refactor: Adapt `docker` for modern logs refactor: Adapt `inject` to modern logs refactor: Adapt `layer` to modern logs refactor: Adapt `pip` to modern logs refactor: Adapt `zip` to modern logs refactor: Adapt `shared` to modern logs refactor: Adapt `clean` to modern logs ...
|
Hi @pgrzesik, branch updated. |
|
That's weird, when I run |
|
@mLupine From what I see it's |
|
@pgrzesik Indeed, missed that. Should be fine now :) |
|
@pgrzesik Well, the check failed again. Seems that |
pgrzesik
changed the title
mLupine
pushed a commit
to mLupine/serverless-python-requirements
that referenced
this pull request
Dec 2, 2021
* master: feat: Add architecture to requirements cache directory name (serverless#645)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Lambdas can be run on arm64 runtimes, Python dependencies with native bindings compiled on x86_64 hosts might not work on Graviton lambdas. This can generate quite a lot of issues with dependencies — for example when using LocalStack on x86_64 but deploying to arm64 runtimes.
This PR adds a suffix with architecture name to the cache directory path so that if dependencies are built for multiple architectures on a single computer, they won't be conflicting each other and there'll be no need to empty cache between those builds.
Side note: If #644 gets merged before this,
getRequirementsLayerPathwill also need to be adjusted.