Correct imprecise regex in moveModuleUp function (fixes #444)

[jimpudar]

The existing regex had the side effect of matching python files
from other modules if their filename or path happened to contain
the string s_.

[jimpudar]

@dschep any comments on this PR? Based on our conversation in #444 it seems to me this should be good to merge.

[dschep]

@alexdebrie can you confirm this will work fine with sls pro?

[jimpudar]

@alexdebrie any comments on this?

[dschep]

welp, he doesn't work at serverless any more either.. @astuyve are there any pythonistas left? 😬

[astuyve]

I'm always game to learn, could we write a bit more about how to reproduce this bug? I'm happy to give it a shot and let you know

[dschep]

If i'm not mistaken, it's taht it would include a file like foos_ball.py when otherwise the include/exclude rules would have excluded it. Mostly wanting to make sure this change doesn't break sls pro.

[jimpudar]

@astuyve, here is a minimal example to show the issue.

Directory structure looks like this:

.
├── package-lock.json
├── package.json
├── package1
│   └── handler.py
├── package2_matches_regex
│   └── handler.py
└── serverless.yml

The serverless.yml file:

service: bug444

provider:
  name: aws
  runtime: python3.8

package:
  individually: true

functions:
  hello1:
    module: package1
    handler: handler.hello
  hello2:
    module: package2_matches_regex
    handler: handler.hello

plugins:
  - serverless-python-requirements

After running sls package and examining the zipped files in .serverless, we can see that the package1-bug444-dev-hello1 zip file contains the spurious package2_matches_regex directory.

package1-bug444-dev-hello1
├── handler.py
└── package2_matches_regex
    └── handler.py

package2_matches_regex-bug444-dev-hello2
└── handler.py

Hopefully it's clear why this is undesirable, let me know if you need any further elaboration.

[bsamuel-ui]

This makes sense based on my reading of the related issue and comments.