-
Notifications
You must be signed in to change notification settings - Fork 293
Issue:414 - Fix Individual deploy of functions #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ndanielsen The patch does not work for me. I cleaned all my plugins and install from your repo. I get the following error.
|
Better fix in #490 Closing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
I created the mentioned issue awhile back.
It seems that the issue is that the serverless framework is no longer setting and passing on the package or artifact (zip file) location (ie func.package.artifact) for the function.
Also the
injectAllRequirements
is no longer passing on thefuncArtifact
, instead it is passed an undefined object.This is more of a patch and I'm not sure if this will break other things. Individual deploys of function and deploying the entire service work for me on my Mac with:
Happy to write tests and etc with any feedback given.