Allow arbitrary extra args to be passed to docker build and dockerized pip install steps #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow arbitrary arguments to be passed to the
docker build
step anddocker run
step in the dockerized pip install case through through the creation of 2 new options:dockerBuildCmdExtraArgs
anddockerRunCmdExtraArgs
, respectively.Both new options accept arrays of strings to be pushed onto the docker command argument arrays.
This is necessary to be able to pass Docker build arguments to the image build step, as well as to be able to attach volumes which may be referenced by the use of a
file://
-style entry inrequirements.txt
.