Skip to content

Allow arbitrary extra args to be passed to docker build and dockerized pip install steps #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2019
Merged

Allow arbitrary extra args to be passed to docker build and dockerized pip install steps #358

merged 4 commits into from
May 24, 2019

Conversation

ChiliJohnson
Copy link
Contributor

These changes allow arbitrary arguments to be passed to the docker build step and docker run step in the dockerized pip install case through through the creation of 2 new options: dockerBuildCmdExtraArgs and dockerRunCmdExtraArgs, respectively.

Both new options accept arrays of strings to be pushed onto the docker command argument arrays.

This is necessary to be able to pass Docker build arguments to the image build step, as well as to be able to attach volumes which may be referenced by the use of a file://-style entry in requirements.txt.

@dschep dschep merged commit f39e166 into serverless:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants