Translate Pipfiles to Requirements in modules #341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin does not properly handle Pipfiles that sit in submodules since the pipenv integration does not anticipate submodules. This commit reworks the pipenv integration such that submodules are supported. This changes will convert Pipfiles into requirements as they are parsed by `pip.js` instead of doing it as a pre-processing step. This is done since the submodule discovery logic sits in pip.js.
leaveningagent
force-pushed
the
la-pipenv-modules
branch
from
4c0c95a to
64631a5
Compare
dschep
approved these changes
Apr 15, 2019
Updates the requirements on [is-wsl](https://github.com/sindresorhus/is-wsl) to permit the latest version. - [Release notes](https://github.com/sindresorhus/is-wsl/releases) - [Commits](sindresorhus/is-wsl@v1.1.0...v2.0.0) Signed-off-by: dependabot[bot] <[email protected]>
leaveningagent
force-pushed
the
la-pipenv-modules
branch
from
1103c4c to
ebae488
Compare
|
I've no clue why the tests cannot find |
leaveningagent
force-pushed
the
la-pipenv-modules
branch
from
c0c00c4 to
ebae488
Compare
|
Is this fix still being implemented as I have this exact issue. Much prefer pipenv over requirements.txt files but this is forcing my hand to use requirements.txt without this fix getting implemented |
This comment has been minimized.
This comment has been minimized.
|
Any news about this issue? Would be nice to have this functionality merged 😄 |
|
will this ever be merged? |
|
Hey @leaveningagent - it's been a long time since this PR was proposed. I'm going to close it, if you feel like the issue is valid, please open a new issue or a new PR against the latest main branch. Thanks 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin does not properly handle Pipfiles that sit in submodules
since the pipenv integration does not anticipate submodules.
This commit reworks the pipenv integration such that submodules are
supported. This changes will convert Pipfiles into requirements as
they are parsed by
pip.jsinstead of doing it as a pre-processingstep. This is done since the submodule discovery logic sits in pip.js.
This closes #268.