use sha256 instead of md5 #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't use md5 for anything that matters, but I'd say this is still a welcome change if it helps you it could help others and still passes all tests. Quick glance at the changes look good to me. |
|
@AndrewFarley Yup, I noticed that it's only using it for filename or something. I think this will help people who needs to be FIPS compliant because md5 will not work at all in those environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
serverless-python-requirementsdoes not work in our environment because this library is using md5. This algorithm is not FIPS compliant. We are getting the following error:digital envelope routines:EVP_DigestInit_ex:disabled for fipsI created this PR so that we can move away from using md5 and use sha256 algorithm which is FIPS compliant.