Skip to content

Preserve binary file permissions in zip #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2019
Merged

Preserve binary file permissions in zip #335

merged 1 commit into from
Mar 21, 2019

Conversation

bspink
Copy link
Contributor

@bspink bspink commented Mar 19, 2019

Fixes #233

@bspink bspink force-pushed the fix-zip-permissions branch from 82a0529 to 6d1308e Compare March 20, 2019 10:06
dschep
dschep approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙂

@dschep
Copy link
Contributor

dschep commented Mar 20, 2019

Hmm, do tests pass for you locally?

@bspink
Copy link
Contributor Author

bspink commented Mar 20, 2019

@dschep they were passing locally for me, but I was running a hacked-up version of the circleci yaml file to run circleci locally using docker containers and most tests were passing (including the 3 new ones added here).

Once it ran on the machine executor I had an issue with an older version of pip (fixed in the PR already). Will fix the issue with the last failing test today. 👍

@bspink bspink force-pushed the fix-zip-permissions branch 3 times, most recently from fdac2e8 to 7e86c36 Compare March 21, 2019 01:45
@bspink bspink force-pushed the fix-zip-permissions branch from 7e86c36 to 68418ae Compare March 21, 2019 02:52
@bspink
Copy link
Contributor Author

bspink commented Mar 21, 2019

@dschep OK, fixed the tests - I was relying on hardcoded permissions values, but now grab them from the appropriate files dynamically.

@dschep dschep merged commit 1c14588 into serverless:master Mar 21, 2019
@davidtsuji
Copy link

Nice work! This fixes an issue I'm seeing. When might this be published to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschep dschep dschep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bspink @dschep @davidtsuji