Adds option to leave python libraries out of the deployment #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-by-line basis by adding a #no-deploy comment beside it in requirements.txt. Creates a parsed .requirements.txt file and retargets pip install to that file.
|
neat suggestion. probably a good enough solution for #14 as well. We're super busy at @unitedincome right now, so I'll look at this when I actually have time. |
dschep
suggested changes
Jun 22, 2017
| this.serverless.cli.log( | ||
| `Parsing Python requirements.txt`); | ||
|
|
||
| var fs = require('fs'); |
There was a problem hiding this comment.
just use fs-extra which is already imported as fse.
| `Parsing Python requirements.txt`); | ||
|
|
||
| var fs = require('fs'); | ||
| var reqs = fs.readFileSync("requirements.txt").toString().split('\n'); |
| var fs = require('fs'); | ||
| var reqs = fs.readFileSync("requirements.txt").toString().split('\n'); | ||
|
|
||
| var newReqs = '' |
| var reqs = fs.readFileSync("requirements.txt").toString().split('\n'); | ||
|
|
||
| var newReqs = '' | ||
| for (var i in reqs) { |
There was a problem hiding this comment.
for (.. of ..) and template strings and triple equal:
for (const req of reqs) {
if (req.indexOf('#no-deploy') === -1) {
newReqs += `${req}\n`;
}
}
bsamuel-ui
reviewed
Jul 12, 2017
| newReqs += reqs[i] + '\n' | ||
| } | ||
| } | ||
| fs.writeFileSync(".requirements.txt", newReqs, 'utf8'); |
There was a problem hiding this comment.
Build tools should use mktemp to avoid clobbering existing files whenever possible.
There was a problem hiding this comment.
(BTW, just using mktemp as an example, you obviously can't write this into /tmp and have it be visible.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue of unnecessarily packaging libraries that are required but included by default by the cloud provider - such as boto3 by AWS.
Done on a line-by-line basis by adding a #no-deploy comment beside the desired library in requirements.txt. Creates a parsed .requirements.txt file and re-targets pip install to that file.
example: