Skip to content

Default noDeploy to an empty list #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2019
Merged

Default noDeploy to an empty list #312

merged 4 commits into from
May 24, 2019

Conversation

jpadilla
Copy link
Contributor

Closes #304

Based on #304 (comment) I changed the default for noDeploy to an empty array. Not entirely sure if it might have been enough to remove boto3 and botocore instead.

Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yes removing all noDeploy defaults is correct.

Two things to do still:

  • There's still a test failure
  • update the docs

@jpadilla
Copy link
Contributor Author

@dschep any help pointing me at how to resolve the issue here? https://ci.appveyor.com/project/dschep/serverless-python-requirements/builds/21861593

@dschep
Copy link
Contributor

dschep commented Jan 28, 2019

Could you try adding - cmd: pip install -U pip before this line https://github.com/UnitedIncome/serverless-python-requirements/blob/master/appveyor.yml#L3

@jpadilla
Copy link
Contributor Author

@dschep thanks! I made tests pass on appveyor, but obviously broken now on circleci...

@jdufresne
Copy link
Contributor

Hi @jpadilla @dschep

I'm interested in seeing this improvement land. Let me know if there is anything I can do to lend a helping hand.

@jdufresne
Copy link
Contributor

The "Omitting Packages" section in README will need some editing to make it accurate.

@jpadilla
Copy link
Contributor Author

@jdufresne just updated this PR with the latest changes in master. Tests are failing again, so I'll need to take a look. Any help is always appreciated.

@jdufresne
Copy link
Contributor

The section in README starting with "To include the default omitted packages ..." should now be removed as well.

Copy link
Contributor

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested doc fix:

diff --git a/README.md b/README.md
index dba4f2f..b1f0054 100644
--- a/README.md
+++ b/README.md
@@ -217,14 +217,6 @@ custom:
       - pytest
 ```

-To include the default omitted packages, set the `noDeploy` option to an empty
-list:
-```yaml
-custom:
-  pythonRequirements:
-    noDeploy: []
-```
-
 ## Extra Config Options

Copy link
Contributor

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpadilla
Copy link
Contributor Author

Appveyor seems to still be failing but seems like for some other reason: https://ci.appveyor.com/project/dschep/serverless-python-requirements/builds/24744154#L186

Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. and your right appveyor isn't related to this

@dschep dschep merged commit 8a6c1a9 into serverless:master May 24, 2019
@jpadilla
Copy link
Contributor Author

@dschep @jdufresne 🙌 thanks!

@stevenolen
Copy link

👋 any chance a release could be cut to include this? It's pretty clunky to have to continue adding a few (soon-to-be) meaningless lines to every project's serverless.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove boto3 and botocore in noDeploy to adhere to AWS best practices.
4 participants