-
Notifications
You must be signed in to change notification settings - Fork 293
Default noDeploy
to an empty list
#312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, yes removing all noDeploy
defaults is correct.
Two things to do still:
- There's still a test failure
- update the docs
@dschep any help pointing me at how to resolve the issue here? https://ci.appveyor.com/project/dschep/serverless-python-requirements/builds/21861593 |
Could you try adding |
@dschep thanks! I made tests pass on appveyor, but obviously broken now on circleci... |
The "Omitting Packages" section in README will need some editing to make it accurate. |
@jdufresne just updated this PR with the latest changes in master. Tests are failing again, so I'll need to take a look. Any help is always appreciated. |
The section in README starting with "To include the default omitted packages ..." should now be removed as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested doc fix:
diff --git a/README.md b/README.md
index dba4f2f..b1f0054 100644
--- a/README.md
+++ b/README.md
@@ -217,14 +217,6 @@ custom:
- pytest
```
-To include the default omitted packages, set the `noDeploy` option to an empty
-list:
-```yaml
-custom:
- pythonRequirements:
- noDeploy: []
-```
-
## Extra Config Options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Appveyor seems to still be failing but seems like for some other reason: https://ci.appveyor.com/project/dschep/serverless-python-requirements/builds/24744154#L186 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. and your right appveyor isn't related to this
@dschep @jdufresne 🙌 thanks! |
👋 any chance a release could be cut to include this? It's pretty clunky to have to continue adding a few (soon-to-be) meaningless lines to every project's serverless.yml. |
Closes #304
Based on #304 (comment) I changed the default for
noDeploy
to an empty array. Not entirely sure if it might have been enough to removeboto3
andbotocore
instead.