Fixes weird bug, where root & submodule requirements weren't packaged correctly #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
This PR fixes a weird bug, that wouldn't let you use a top-level
requirements.txt
alongside sub-modulerequirement.txt
-files.Problem
The previous (I guess) unwanted behavior was, that when you had a root level function (i.e.
module: .
) with arequirements.txt
and a second (sub-module) function (i.e.module: my_submodule
) the first function didn't receive any requirements at all, whereas all requirements (from root and submodule) ended up in the artifact for function two:see sample code: https://github.com/bweigel/serverless_playground/tree/293_weird_bug/sls_package
serverless.yml
:The top-level requirements are not packaged for
function-one
:but are instead included in
function-two
(where they don't belong):Relates to