Allow 'strip' to be run via docker #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alled correctly. - Make sure we're consistently quoting arguments. - Add mergeCommands function to construct a script for docker to run when needed. - Add getStripMode to run strip correctly for the platform and docker.
Closed
dschep
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check the best way to run strip, and run it either in the outside environment or in docker.
Since Mac OS X's strip can't process ELF objects, it has simply been failing. You can use the version of strip from GNU binutils, but that would require passing the path to your strip.
So since we have strip installed in lambci, it seems easiest to use that. This PR disables using strip on
darwinandwindows, but it will always use strip in docker mode. (Maybe the canonical way would be to pass a minimal ELF object to strip to see if it succeeds?)This also cleans up how we're quoting arguments and building the commands. Basically, I take a "command" to be an "array of unqouted strings" and defer the responsibility of quoting. Hopefully the logic to build the commands is a bit more straightforward and extensible.
I'm not sure of a great way to test that strip runs in docker; any suggestions are welcome.