-
Notifications
You must be signed in to change notification settings - Fork 293
override slimPatterns instead of appending #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the documentation to reflect that this option no longer adds, but overrides the slim pattern https://github.com/UnitedIncome/serverless-python-requirements#custom-removal-patterns
@dschep I added a new option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Think you could add some test coverage too? Probably easiest to add to the node tests in test.js
rather than dealing with bats. run node test.js
to run them.
I'll look into the tests later. I am not very knowledgable when it comes to node & testing, so I'll have to look into it. |
don't worry if you can't figure it out. just let me know and i'll take care of it. |
one more thing, could you run |
-reformat code usin `npm run format`
I have migrated the tests from bats to |
@dschep do you have some clue or hints on how to deal with the failing tests (i.e. docker is missing in the AppVeyor CI system)? I am guessing in bats these tests are always skipped via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a function to check if Docker can be used in JS & how to use it. Tthis should actually cover all the use cases that bats was checking for (meaning, docker is usable, not just present)
add function to check for working docker Co-Authored-By: bweigel <[email protected]>
skip test if docker isn't available Co-Authored-By: bweigel <[email protected]>
sweet. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
closes #216