Add support for remote DOCKER_HOST #270
Conversation
|
Nice PR! Thanks @str3tch. Could you run |
|
ok great! I'll try and get around to this in the next week or so. cheers! |
| pythonRequirements: | ||
| dockerizePip: true | ||
| dockerRemoteHost: true | ||
| proxy: http://yourproxy:8080 |
There was a problem hiding this comment.
I just merged #271. Please remove the proxy option as users can use the dockerEnv feature to pass proxies in.
| custom: | ||
| pythonRequirements: | ||
| dockerizePip: true | ||
| dockerRemoteHost: true |
There was a problem hiding this comment.
Should the plugin maybe not actually have an option for this, and automatically do all the volume stuff if DOCKER_HOST is set?
|
Sorry for delay on getting this sorted, smashed at work at the mo. I did do a yarn format but still seems to complain.. will try and take a look next week and get some tests together. |
|
Is there any update on this? 😃 |
|
Any news on this? It's required to run on CI engines like CircleCI which utilize remote docker machine |
|
Hey guys, apologies.. been snowed under at work and have a newborn at home - pretty hectic! I’ll try and get to it, but it’s not going to be asap .. if anyone wants to tidy it up, not much to do to get it passing another review. |
miketheman
added
Docker
waiting-on-response
|
Any update on this? I'd much appreciate being able to run the packaging on a remote docker host as well. |
|
Hey @str3tch - it's been a long time since this PR was proposed. I'm going to close it, if you feel like the issue is valid, please open a new issue or a new PR against the latest main branch. Thanks 🙇 |
Hi,
On our corporate network, we have a remote docker machine (defined in the DOCKER_HOST env var), rather than being able to spin up containers locally. This means that when you use Dockerizepip, it fails when trying to mount the volume (can't mount local filesystem to a remote docker server). So.. the fix is that instead of mounting the local folder, create a docker volume, copy the files into it, mount that to the container, do the pip install magic, then copy the files back off the container.
I've got this working, see this PR. I have run the tests and they pass, but I can't get the BATS tests to run on my Mac. so not quite there.
I am willing to beef up the testing if it's required.. but first I'd like feedback that this PR is something that you're actually interested in.
Let me know..
cheers!
Str3tch