honor escaped newlines in requirements.txt #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you test this @brettdh? |
dschep
force-pushed
the
reqs-with-newlines
branch
2 times, most recently
from
b1b7c28 to
ddb3d77
Compare
|
Yep, this fixes the escaped newlines problem for me. AFAICT the issue with blindly stripping out boto3 and other builtin deps remains, but I'm fine with the |
|
What's the status of this? I can't quite make sense of the CI failure at a glance, but as I mentioned, this seems to resolve #261 for me. |
dschep
force-pushed
the
reqs-with-newlines
branch
from
6978d7d to
4a2eeb1
Compare
|
Hey, sorry I failed to follow up on this. I just rebased, and will merge if tests pass or figure out why if not. |
|
released in v4.2.5 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #261