Skip to content

First pass at tape tests instead of bats tests #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2018
Merged

First pass at tape tests instead of bats tests #254

merged 3 commits into from
Oct 11, 2018

Conversation

dschep
Copy link
Contributor

@dschep dschep commented Sep 20, 2018 •
edited
Loading

Main advantage is that these can run on windows more easily, thus fixes #249

cc @AndrewFarley @kichik @heri16

@dschep dschep added the Windows label Sep 20, 2018
@AndrewFarley
Copy link
Contributor

This is great @dschep thanks for bootstrapping this. If you want a hand with something in particular or a second eye let me know. Happy to help. Cheers!

@dschep
Copy link
Contributor Author

dschep commented Sep 20, 2018 •
edited
Loading

Thanks @AndrewFarley. I currently need help debugging the errors with npm not being found by spawnSync in appveyor, if someone with Windows could try to run the tests locally (clone this branch, then: npm i && node test.js) that would be much appreciated. For further help, I'm gonna first get the skip conditions worked out (ie: when not to run the docker tests) and then I'll probably want some help just porting over the remaining tests.

edit: nevermind re debugging spawnSync, googling explained the issue and switching to cross-spawn did the trick.

@dschep
Copy link
Contributor Author

dschep commented Sep 21, 2018

woo hooo. tests passing. temporarily cherrypicked a "fix" for #252 to make it happen

dschep added 3 commits October 11, 2018 12:53
@dschep
simpler test cleanup
63edf6b 
precursor to JS version since i want it as simple as possible before port
@dschep
move 1st test down.. probably too much but its not the first/primary …
eb53a71 
…test
@dschep
First pass at tape tests instead of bats tests
eb8cc11 
Main advantage is that these can run on windows more easily, thus fixing #249
@dschep
Copy link
Contributor Author

dschep commented Oct 11, 2018

Merging this now as it's already way better than the current(broken) windows test coverage.

@dschep dschep merged commit 7245bcc into master Oct 11, 2018
@dschep dschep mentioned this pull request Oct 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proper windows CI test coverage
2 participants
@dschep @AndrewFarley