Bugfig, allowing all paths to have spaces #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242
Problem
Could not use this plugin with any path that contains a space character due to missing/insufficient shell escaping/quoting.
Solution
I'm sorry I couldn't find a simple "quote-all" solution similar to what was in place pre-merge. These solutions fall apart because certain things you can't quote or docker freaks out, for example features like the 'slim' would fall apart... eg: (see the last line)
The "simple" single test you added for testing in a subfolder only tests one of many use-cases that use various inputs for volumes, caching, etc. This MR I tested (as you see above) running ALL tests from a folder with a space in it, confirmed working. Just, not as clean as I would like, but I spent 4 hours trying to make it work with a quote all args type mechanism. If you don't like this MR's style, please let me know, but I'm out of effort/time/etc. I can post my diff for my attempts as using a simpler quote-all if interested. I did not, however, go test if this breaks anything on Windows. :\ We really need automated testing on Windows somehow @dschep.