Skip to content

Update tests #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Update tests #239

merged 2 commits into from
Sep 14, 2018

Conversation

dschep
Copy link
Contributor

@dschep dschep commented Sep 13, 2018

  • Don't skip non-docker tests when docker isn't present
  • Don't hard code a static cache md5sum

@AndrewFarley, I noticed that tests were failing on #238 and got the same errors locally on master. Do you think it's reasonable to compute the md5sum this way? I don't like hard coding the hash. But, I understand that this makes the test verify less of the process. Best would probably be to externally replicate what genrerateRequirementsFile does to create a new file and md5sum that instead of .serverless/requirements.txt

 * Don't skip non-docker tests when docker isn't present
 * Don't hard code a static cache md5sum
@dschep
Copy link
Contributor Author

dschep commented Sep 13, 2018

I've updated to replicate the requirements file generation too (required a few tweaks: leave out blank lines and add a new line at the end of the file as is standard in *nix environments) so that this doesn't rely on .serverless/requirements.txt for md5sums

@AndrewFarley
Copy link
Contributor

@dschep This looks like a good fix, and would keep things from breaking in the tests if/when that requirements file changes. +1 from me on this

@dschep dschep merged commit e14aac9 into master Sep 14, 2018
@dschep dschep deleted the test-updates branch September 14, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants