Only pack requirements for Python runtimes #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbonami
commented
Jun 15, 2018
| @@ -376,6 +376,56 @@ teardown() { | |||
| ! ls puck2/pyaml | |||
| } | |||
|
|
|||
| @test "py2.7 can package module requirements with zip option" { | |||
There was a problem hiding this comment.
@dschep Is it expected functionality for the zip flag not to move up the root module?
There was a problem hiding this comment.
I don't think so. That seems to be the cause of #203
There was a problem hiding this comment.
I managed to fix this problem, by doing this: felipe-augusto@2a14d92
But I don't know if this is the desired behavior.
sbonami
deleted the
Only-Pack-Requirements-for-functions-with-Python-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.