Skip to content

Fix related to test #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2018
Merged

Fix related to test #193

merged 2 commits into from
May 21, 2018

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented May 18, 2018

  • Add file to clean in test teardown
    • Because git is displayed in an untracked file
  • Fix package.json of test according to the current version
    • Because it was displayed in git diff

abetomo added 2 commits May 18, 2018 15:21
@abetomo
Add file to clean in test teardown
dceb7ca 
Because git is displayed in an untracked file
@abetomo
Fix package.json of test according to the current version
4f47778 
Because it was displayed in `git diff`.
dschep
dschep approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abetomo!

@dschep dschep merged commit d4e199c into serverless:master May 21, 2018
@abetomo abetomo deleted the clean_files_used_for_testing branch May 22, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschep dschep dschep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @dschep