Fix paths for Docker on Windows #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using on Windows with the default docker configuration, it passes `.serverless\\requirements.txt` to `docker ... pip install ...`. This results in the following error: ``` Could not open requirements file: [Errno 22] Invalid argument: '.serverless\\requirements.txt' ``` To fix this, we can convert the paths from Windows style to Linux style when running on Windows with `dockerZip: true`.
|
@heri16, what are your thoughts on this? You did most of the windows work in this plugin. |
|
Looks good. Sorry been away from some time. Now back and available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using on Windows with the default docker configuration, it passes
.serverless\\requirements.txttodocker ... pip install .... This results in the following error:To fix this, we can convert the paths from Windows style to Linux style when running on Windows with
dockerZip: true.