-
Notifications
You must be signed in to change notification settings - Fork 293
Implement a prereqCmd option for installing system deps #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
841f090
to
b88bea8
Compare
However! Another approach I have considered in the past is building a serverless plugin just for installing system dependencies. Thoughts on that approach? (you'd just add |
@dschep Glanced at the files changed, looks great. Will try it out this evening and let you know. Cheers! |
Hey @dschep a quick check of this and it doesn't seem to run prereqCmd at all for me.
I tried both ways, inline shell and included file. I dropped some debug echoes into the prereqCmd.js and that function never gets executed. Am I missing something? |
Hmm.. When you did an included file, how did you specify the name/path? In my test I used |
Well... the prereq command isn't even running at all for me, as I said I threw some quick debug console logs in there to show it. A good example to test against, it making sure that requirements.txt has "mysqlclient" in it, and that pip package compiles properly. Might want to add that to your test to be sure it works. |
did you try again with the new commits? |
Yeah, still no go. I don't know if it's because I'm on OS-X, or perhaps using it dockerized? |
mmm yeah, i'll have to test it dockerized. |
Yeah, sorry @dschep the whole point of this was for use while in dockerized pip mode. Otherwise, I would/could have just done some simple wrapper to install and some local system libraries. :) Hoping this can still happen one day soon though. |
open |
@@ -113,6 +113,16 @@ custom: | |||
pythonBin: /opt/python3.6/bin/python | |||
``` | |||
|
|||
### Run Custom extra packaging scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+### Run Custom extra packaging scripts
@Arsen00, What? |
closes #101
Test this out and let me know if it fulfills your requirements @AndrewFarley
(install with
npm i UnitedIncome/serverless-python-requirements@prereq-script
)