Skip to content

editable flags -e in requirements.txt don't work #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simplesteph opened this issue Jun 21, 2017 · 5 comments · Fixed by #507
Closed

editable flags -e in requirements.txt don't work #36

simplesteph opened this issue Jun 21, 2017 · 5 comments · Fixed by #507
Labels
bug confirmed bug confirmed good first PR A good issue for new contributors to tackle

Comments

@simplesteph
Copy link

requirements.txt

-e git+git://github.com/ojii/pymaging.git#egg=pymaging
-e git+git://github.com/ojii/pymaging-png.git#egg=pymaging-png

throws error:

Serverless: Installing required Python packages for runtime python2.7...
 
  Error --------------------------------------------------
 
  Command "/Users/stephanemaarek/.pyenv/versions/2.7.12/bin/python2.7 -c "import setuptools, tokenize;__file__='/Users/blah/projects/python-s3-thumbnail/src/pymaging/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" --no-user-cfg develop --no-deps --home=/var/folders/x5/gcz23y8x62v7v2bx49rt00wr0000gn/T/tmpGP7oYR" failed with error code 1 i

tried both with and without docker

@simplesteph simplesteph changed the title git based requirements.txt don't work editable flags -e in requirements.txt don't work Jun 21, 2017
@dschep dschep added the bug label Jun 21, 2017
@simplesteph
Copy link
Author

removing -e fixes the problem as a temporary fix

@mwillfox
Copy link

mwillfox commented Apr 9, 2018

Just wanted to add that pipenv also does not work for git due to the requirements.txt generated by pipenv having the -e flag.

For anyone needing a workaround for SSH access to GitHub, use the format git+ssh://[email protected]/$org/$repo.git#egg=$egg.

@lyoungblood
Copy link

@simplesteph thanks for this tip - worked for me.

@jacksgt
Copy link
Contributor

jacksgt commented Apr 17, 2020

Looking at the logic in lib/pip.js in detail, it seems only options starting with -- as well as -i and -f are respected.
https://github.com/UnitedIncome/serverless-python-requirements/blob/master/lib/pip.js#L391

I'll create a PR to fix that, but as a workaround you can just use --editable instead of -e:
https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format

@miketheman miketheman added confirmed bug confirmed good first PR A good issue for new contributors to tackle labels Apr 18, 2020
@miketheman
Copy link
Contributor

miketheman commented Apr 18, 2020

I'll create a PR to fix that, but as a workaround you can just use --editable instead of -e

@jacksgt We'll be on the lookout for it! Please consider adding a test case as a separate commit, so we can rework it when #482 is merged.

jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Apr 19, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
jacksgt added a commit to jacksgt/serverless-python-requirements that referenced this issue Oct 2, 2020
Previously, requirements with the -e flag where completely ignored
serverless#36

With the latest patch, the -e flag are stripped out, but the
requirement itself is preserved.

This patch adds a check to test this desired behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug confirmed good first PR A good issue for new contributors to tackle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants