-
Notifications
You must be signed in to change notification settings - Fork 293
pyproject.toml does not mean you want to use poetry #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the push. I was concerned about this potentially being an issue: #308 (comment) & #308 (comment) Am I right in reading pep 518 that there's no explicit declaration in the toml of what tool is being used? Should the plugin infer that you're using poetry if there's a |
I am having the same issue after adding Black to my project, here is my [tool.black]
line-length = 79
py36 = true
skip-string-normalization = true
exclude = '''
/(
\.serverless
| node_modules
)/
''' Poetry isn't referenced anywhere. This should not be the default behavior. |
I have not studied PEP 518 since I just wanted to do some simple configuration for black, so I'm not the best source here 😞 From my simple understanding you have to look at the Example: [build-system]
requires = ["setuptools", "wheel"] If I understand correctly So I think for simplicity you can assume that if |
What's the status on fixing this? I, too, have added |
What I did in my case was to disable poetry from the Python Requirements configuration in pythonRequirements:
usePoetry: false |
@s16h as @BigChief45 mentioned, you can explicitly disable poetry. I will do my best to try and work on this next week. |
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs #324 Refs #344 Fixes #400 Signed-off-by: Mike Fiedler <[email protected]>
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
After adding a
pyproject.toml
file to configure https://github.com/ambv/black this plugins suddenly outputs "poetry not found! Install it according to the poetry docs.".I do not intend to use poetry, and PEP-518 is not in any way tied to poetry alone.
As a workaround I know I can add
usePoetry: false
to serverless.yml, but I don't think it's a good idea to automatically tiepyproject.toml
to poetry as there are other use cases for it.The text was updated successfully, but these errors were encountered: