Skip to content

Zip injection code breaks executable permissions #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dschep opened this issue Apr 6, 2018 · 1 comment · Fixed by #178
Closed

Zip injection code breaks executable permissions #166

dschep opened this issue Apr 6, 2018 · 1 comment · Fixed by #178
Assignees
@bsamuel-ui
Labels
bug

Comments

@dschep
Copy link
Contributor

dschep commented Apr 6, 2018

The new zip injection technique uses the abandoned zip-local package instead of jszip like serverless does. If you have an executable in your bundle, the execute bit is now lost.
@dschep dschep added the bug label Apr 6, 2018
dschep added a commit that referenced this issue Apr 6, 2018
@dschep
Test proving #166
d2d4730
@bsamuel-ui bsamuel-ui mentioned this issue Apr 19, 2018
Merged
@bsamuel-ui
Copy link
Contributor

PR up for this #178.

@bsamuel-ui bsamuel-ui mentioned this issue Sep 7, 2018
Closed
@bsamuel-ui bsamuel-ui mentioned this issue Nov 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsamuel-ui bsamuel-ui

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use JSZip 3.x to handle zip files bsamuel-ui/serverless-python-requirements
2 participants
@dschep @bsamuel-ui