Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(lambda-at-edge): initial support for routing to locale-specific … #884

Merged
merged 2 commits into from
Jan 24, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jan 23, 2021

…pages

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #884 (2e1c6fe) into master (8bc889c) will increase coverage by 0.02%.
The diff coverage is 81.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   80.38%   80.41%   +0.02%     
==========================================
  Files          63       63              
  Lines        2279     2313      +34     
  Branches      518      527       +9     
==========================================
+ Hits         1832     1860      +28     
- Misses        385      391       +6     
  Partials       62       62              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 89.77% <78.84%> (-0.91%) ⬇️
...ackages/libs/lambda-at-edge/src/default-handler.ts 94.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc889c...2e1c6fe. Read the comment docs.

@dphang dphang merged commit b4666d3 into master Jan 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/locales-support-2 branch January 24, 2021 05:01
@karthikcodes6
Copy link

Hi, when can we start using this feature?

@dphang
Copy link
Collaborator Author

dphang commented Jan 24, 2021

@karthikeyan676 still need one more change to support accept-language and some testing/fixing some bugs I found. I think it can be ready in by next few days

@karthikcodes6
Copy link

karthikcodes6 commented Jan 25, 2021 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants