Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(lambda-at-edge): start copying locale-specific page/data files t… #883

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jan 22, 2021

…o output assets

  • First part of: Next.js 10 localization in pathname #721, to copy all locale-specifi page/data files to the assets output directory.
  • Second part is to add the routes for these pages in manifest
  • Need to add some unit tests

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #883 (14ad854) into master (3db3238) will decrease coverage by 0.03%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   80.42%   80.38%   -0.04%     
==========================================
  Files          63       63              
  Lines        2258     2279      +21     
  Branches      514      518       +4     
==========================================
+ Hits         1816     1832      +16     
- Misses        380      385       +5     
  Partials       62       62              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 90.68% <73.68%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db3238...14ad854. Read the comment docs.

@dphang dphang merged commit 8bc889c into master Jan 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/locales-support branch January 22, 2021 23:30
@karthikcodes6
Copy link

When can we start to use this feature?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants