This repository was archived by the owner on Jan 28, 2025. It is now read-only.
Add support for APIs #117
Merged
Add support for APIs #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this work for Dynamic API routes? For example... |
|
Good question, not in this change but I can't see why it wouldn't after #99 is merged. I'll test with that pull request in the next couple of days since I've only used it with static API paths so far. |
There are only a few minor issues with the current implementation to get this going, namely: - Allowing POST, PATCH etc. in Cloudfront. - Checking if the NextJS page is a React component or not. The change to `compatLayer.js` is needed so that if a request without a body is sent to an API the Stream still has some content. Without a `_read() is not implemented` is raised which generates an HTTP 400 response without a body. The stream test case is removed since the stream already has EOF pushed to it. Don't think there is a use case where the input is a stream itself. #116
|
Looks great! Thanks 🙏 |
This was referenced Aug 15, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only a few minor issues with the current implementation to
get this going, namely:
The change to
compatLayer.jsis needed so that if a request withouta body is sent to an API the Stream still has some content. Without
a
_read() is not implementedis raised which generates an HTTP 400response without a body.
The stream test case is removed since the stream already has EOF pushed
to it. Don't think there is a use case where the input is a stream
itself.
#116