-
-
Notifications
You must be signed in to change notification settings - Fork 460
.serverless and .serverless_nextjs should be included on .gitignore? #415
Comments
You should include .serverless in your repository until the serverless framework removes the need for this. |
@medv you mean |
It just contains resource definition and their ARNs. You also don't need to include |
Has any solution to commit without AWS resources' arns? about terrafrom reference link here: |
There are other recent issues here that demonstrate how to put |
@medv Oh Yes, I didn't think about that. |
Yeah, putting it in a remote file store is the way to go. In github actions, I S3 copy before deploy then S3 copy back after. This has the problem of parallel deployments conflicting but it may not matter as I've re-deployed with slightly out of date infrastructure config and it still worked. |
This document from the CEO of serverless includes the statement
Does this mean that the .serverless folder no longer requires to be part of the repository? It is mentioned in the docs of this project that serverless were working on a solution to store state - I assume that the above link was the announcement of this event! |
That is correct, however, to benefit from this the nextjs component needs to be upgraded to use the new serverless components version which introduced some breaking changes. I have already started working on the upgrade and should have more info on that soon. |
It may also be a valuable option for some folks to be able to specify an s3 bucket to store the state files and then simply recover this at the start of each deploy.
This is an approach I have seen taken elsewhere and is reported to work well.
G
Graeme Bryce
+44 (0) 7745 056933
[email protected]
… On 27 May 2020, at 15:02, Daniel ***@***.***> wrote:
This document from the CEO of serverless includes the statement
Every Component now stores its state automatically in the cloud, so you can easily collaborate on them and run them in CI/CD.
Does this mean that the .serverless folder no longer requires to be part of the repository?
It is mentioned in the docs of this project that serverless were working on a solution to store state - I assume that the above link was the announcement of this event!
That is correct, however, to benefit from this the nextjs component needs to be upgraded to use the new serverless components version which introduced some breaking changes. I have already started working on the upgrade and should have more info on that soon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Hi Daniel, |
I think this can be closed. With the CDK construct it should be easier to manage state via the CDK / and you can customize it, and there are other workarounds using the normal deployer (https://github.com/serverless-nextjs/serverless-next.js#cicd-multi-stage-deployments--a-new-cloudfront-distribution-is-created-on-every-ci-build-i-wasnt-expecting-that).. Though we could possibly still upgrade to get parity for the legacy deployer (though not sure we will keep adding new configuration there if the CDK makes IaC easier) |
- serverless.ymlの追加 - [email protected]をインストール `yarn serverless`でawsへデプロイ可能 3系ではエラーがでて進めないので旧バーションを指定している serverless-nextjs/serverless-next.js#2320 - また、.serverless/.serverless_nextjsをgitignoreに追加した。 FYI: serverless-nextjs/serverless-next.js#415
I wonder
.serverless
and.serverless_nextjs
should be ignored or not.because if I add
.serverless
to.gitignore
and I pull my project to another PC, I can't deploy it on another PC.I can see
CNAMEAlreadyExists
Error Code only.So, now I don't add
.serverless
to.gitignore
but I am a nervous little bit because I don't know it is fine.If I should
.serverless
with.gitignore
, how can I avoidCNAMEAlreadyExists
Error?The text was updated successfully, but these errors were encountered: