Feature/initial attempt #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 10, 2018 15:02
cocowalla
reviewed
Dec 19, 2018
| { | ||
| gzipStream.Write(buffer, 0, bytesRead); | ||
| } | ||
| inputStream.CopyTo(gzipStream, bufferSize); |
There was a problem hiding this comment.
Such a small buffer size is going to result in sub-par compression ratios - what's the purpose of overriding the default buffer size here? (I guess the default is 64K?)
cocowalla
reviewed
Dec 19, 2018
| var buffer = new byte[1024]; | ||
| int bytesRead; | ||
| int bufferSize = 1024; | ||
| var buffer = new byte[bufferSize]; |
There was a problem hiding this comment.
I don't think buffer is being used?
cocowalla
reviewed
Dec 19, 2018
| @@ -174,7 +190,8 @@ void AlignCurrentFileTo(DateTime now, bool nextSequence = false) | |||
| { | |||
| var directoryFileName = Path.GetFileName(directoryFile); | |||
|
|
|||
| if (!(directoryFileName.Contains("-GZip"))) | |||
| // Not sure if we can assume log files will always be .txt? | |||
There was a problem hiding this comment.
Nope 😄
The filename (and extension) are configurable by the user
cocowalla
reviewed
Dec 19, 2018
| /// </summary> | ||
| /// <param name="logFile"> The log file to be compressed </param> | ||
| /// <param name="logDirectory"> The directory that holds logFile </param> | ||
| public void GZipCompress(string logFile, string logDirectory) |
|
@AdamUdovich I think #80 is going to enable this; I'm catching up and doing a bit of housekeeping, so I'll close the PR here - kudos for pushing it forwards :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff for rolling compression.