Added an overload of File() that accepts an ITextFormatter #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge, just in case the last sentence of the PR description created any doubt :-) |
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4. Usage is:
The existing signature accepts both an output template and format provider, to create
MessageTemplateTextFormatterunder the hood. This one omits both of those parameters and accepts the formatter directly as the first arg.There are two options for positioning: first, before the path, or second, after it. Not sure if I have a strong preference either way - adding it first gets rid of the intellisense ambiguity as soon as the user has specified a path, so might be the cleaner option in usage.
Once merged this should publish a
2.1.0-dev-nnnpackage version.