Added ability to roll on specific day of week as described by #325 #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #325 (comment) - TL;DR unfortunately I think this is a step too far for this repo. |
|
PR Closed: This repo is not taking any new features / enhancements. |
|
(for other readers that hav not seen the other thread)
... that have not gone through a feature proposal discussion phase (particularly ones that adjust the naming or rolling strategy) (as covered in the #325 discussion) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to roll the log file on a specific day. This implementation should address the drawpacks of previous pull requests:
#182
#204