Add ability to capture path of log file opened, via FileLifecycleHooks

[augustoproiete]

Adds an overload to FileLifecycleHooks that includes the path to the log file that has been opened.

public virtual Stream OnFileOpened(string path, Stream underlyingStream, Encoding encoding) { ... }

By default, it calls the current OnFileOpened(Stream, Encoding) to maintain compatibility with existing hooks.

We can consider marking the current OnFileOpened(Stream, Encoding) as Obsolete on this or on a future pull-request depending on the next milestone/release.

---

Resolves #191

[nblumhardt]

Looks good to me; which scenario are we aiming to hit with this, in particular?

[augustoproiete]

@nblumhardt @cocowalla I just did what I should have done from the start and opened an issue to discuss and add more context.

[nblumhardt]

[Falco20019]

Is there a roadmap on when this gets released? We are waiting for this. Our use case is having encryption applied on the file. When appending, we need to read the initialization vector from the header. Since neither the underlying stream nor the file name is offered through WriteCountingStream, we have no way in appending existing files right now.

Another problem that we have, is that the underlying stream is opened with FileShare.Read. If you want to append an encrypted stream, you need to decrypt the last block to remove the padding before writing the next data. So this is currently not possible.

[nblumhardt]

Hi @Falco20019 - have you tried the -dev package, and does it work for you? Feedback would be great, thanks 👍

[Falco20019]

@nblumhardt Yes, I tried it with that and that‘s when I saw the problems I documented in #199. So sadly this was only part of the solution since the underlying stream is not allowing write permission as it already opened the file with FileShare.Read.