Make shared log files readable while in use #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,13 +61,7 @@ public FileSink(string path, ITextFormatter textFormatter, long? fileSizeLimitBy | |||
| Directory.CreateDirectory(directory); | |||
| } | |||
|
|
|||
| #if ATOMIC_APPEND | |||
| // FileSystemRights.AppendData improves performance substantially (~30%) when available. | |||
There was a problem hiding this comment.
Made an error while benchmarking: the improvement was due to another change brought in accidentally (the removal of CharacterLimitingTextWriter, not this flag, so reverting the little accommodation here.
|
Pushing through to dev so that we can get some wider usage, it'd be nice to send this on towards master as soon as possible :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed the
FileShare.Readoption in the original implementation :-OFixes serilog/serilog-sinks-rollingfile#20