Enable auditing #12
Merged
Enable auditing #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| FileSink sink; | ||
| try | ||
| { | ||
| sink = new FileSink(path, formatter, fileSizeLimitBytes, buffered: buffered); | ||
| } | ||
| catch (ArgumentException) |
There was a problem hiding this comment.
The precondition checks have always thrown in File(); this PR changes what throws/what doesn't very slightly, in that invalid path errors are now always suppressed in WriteTo scenarios and always propagate with AuditTo.
In general it's really hard to pin down which argument errors should be throwing ones. Serilog aims to always propagate API usage errors, and always (by default) suppress environmental/transient/runtime errors. In the case of the System.IO APIs and various configuration providers the line is fuzzy at times.
|
Merging so that the downstream items (XML and JSON support) can be kicked off :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serilog/serilog#828
This makes
AuditTo.File()work with Serilog 2.2-*.