Skip to content

Add support C# 8 nullable reference types #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
rafaelsc opened this issue Jul 22, 2020 · 4 comments
Closed
2 of 8 tasks

Add support C# 8 nullable reference types #165

rafaelsc opened this issue Jul 22, 2020 · 4 comments

Comments

@rafaelsc
Copy link
Contributor

Does this issue relate to a new feature or an existing bug?

  • Bug
  • New Feature

What is the target framework and operating system affected by this issue? Please see target frameworks & net standard matrix.

  • netstandard2.1. NEW
  • netCore 2.0
  • netCore 1.0
  • 4.7
  • 4.6.x
  • 4.5.x

Describe the solution you'd like
Enable nullable-references in Serilog and add update the codebase to support the nullable reference types in .NET Core 3.0 and 3.1.

Additional context
Links about the *Nullable reference types *:

@Numpsy
Copy link
Member

Numpsy commented Jul 29, 2020

A small Q. with regards to #139 and the netstandard2.1 project change:

image

Could the dependencies be reduced in the 2.1 target, even if the existing 2.0 target is left the same?

@Numpsy
Copy link
Member

Numpsy commented Jul 29, 2020

/meant to put that comment in the PR :-(

@rafaelsc
Copy link
Contributor Author

I had a quick look and look like none of this PackageReference are required for any netstandard (even the netstandard1.3).
I will test more asap and probably create a new PR if we can clean up this PackageReference

@rafaelsc
Copy link
Contributor Author

Just created a new PR #172 to remove unnecessary references in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants