Skip to content

Installing on .net core 3.1 app require 12 dependencies instead of 4. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DmytroLohvynenko opened this issue Apr 15, 2020 · 3 comments
Closed

Comments

@DmytroLohvynenko
Copy link

DmytroLohvynenko commented Apr 15, 2020

In nuget package description stated that for .net standard 2.0 it should be only 4 dependencies.
image

But when I try to install on .net core 3.1 console app, I see prompt with 12 dependencies. Is is correct?
image

@nblumhardt
Copy link
Member

Hi! May be related to #104 - can you please try out the latest -dev release of this package? Thanks!

@Numpsy
Copy link
Member

Numpsy commented Jun 25, 2020

Same thing here - installing the 5.0.0 dev release into a .NET Core 3.1 console app only wants Serilog, but installing it into a Core 2.1 app or a .NET Standard 2.1 library wants many more (because System.IO.FileSystem has a bunch of dependencies of it's own?):

image

As the comment in #130 says, is there a need for those extra libs when targetting Standard 2.1 or 2.0?

@nblumhardt
Copy link
Member

Thanks for the follow-up. I think we'll get diminishing returns trying to modify the dependency graph targeting older .NET Core versions; since all is fine on 3.1 let's close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants