Skip to content

File Version in 1.3.0 Release Incorrect #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jul 27, 2018 · 1 comment
Closed

File Version in 1.3.0 Release Incorrect #37

ghost opened this issue Jul 27, 2018 · 1 comment
Labels
bug up-for-grabs

Comments

@ghost
Copy link

ghost commented Jul 27, 2018

Serilog.Sinks.Async.dll 1.1.0 has a FileVersion of 1.1.0. Recently upgrading to 1.3.0 and the Serilog.Sinks.Async.dll has a FileVersion of 1.0.0. I would expect the FileVersion to be 1.3.0 or at least greater than one of the previous versions. The FileVersion instead has gone backwards. This causes issues with some installer technologies.
@nblumhardt
Copy link
Member

Thanks for the report, not sure what went wrong in the here, but I know firsthand how annoying that MSI behavior is! Help tracking this down appreciated, if anyone can pick this up.

mattpwhite pushed a commit to mattpwhite/serilog-sinks-async that referenced this issue Aug 6, 2018
Make file version match assembly version
7f397e1 
Fixes serilog#37
@mattpwhite mattpwhite mentioned this issue Aug 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nblumhardt