Fix build script and move approval test into new project #372
Conversation
|
why split out approval test? |
|
To align build process with core repo where approval test is its own project. |
|
i would argue the core project should have i merged back into the main test project @nblumhardt |
|
If merged, this will break my efforts to run tests in parallel on AppVeyor which works around dotnet/sdk#19147. |
I'm fine either way. |
|
I've just added approval tests to Serilog.Sinks.OpenTelemetry directly in the main unit test project. Needing to rely on an additional assertions library (Shouldly) is a marginal negative but probably not enough to justify the additional project, since we're already very relaxed about test project dependencies. Seems like this one should be closed RE the parallel testing effort; if it needs more consideration or reopening please just sing out :) |
Use `throw` to exit when a `dotnet` command fails so that errors are properly reported on AppVeyor. See also serilog#372
Use `throw` to exit when a `dotnet` command fails so that errors are properly reported on AppVeyor. See also serilog#372
See serilog/serilog#1887 . I moved approval test into new project to align build process with core repo.