Switch to Microsoft.Extensions.Logging.Abstractions #191
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All"/> | ||
| </ItemGroup> | ||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||
| <Project> | ||||||
| <ItemGroup> | ||||||
| <PackageVersion Include="Serilog" Version="2.10.0" /> | ||||||
| <PackageVersion Include="Serilog.Sinks.Console" Version="3.1.1" /> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="5.0.0" /> | ||||||
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="5.0.0" /> | ||||||
| <PackageVersion Include="Microsoft.Extensions.Logging" Version="5.0.0" /> | ||||||
| <PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="5.0.0" /> | ||||||
| <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="16.10.0" /> | ||||||
| <PackageVersion Include="xunit.runner.visualstudio" Version="2.4.3" /> | ||||||
| <PackageVersion Include="xunit" Version="2.4.1" /> | ||||||
| <PackageVersion Include="BenchmarkDotNet" Version="0.13.0" /> | ||||||
| <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.0.0" /> | ||||||
| </ItemGroup> | ||||||
| </Project> | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,5 +8,5 @@ for path in src/**/*.csproj; do | |
| done | ||
|
|
||
| for path in test/*.Tests/*.csproj; do | ||
| dotnet test -c Release ${path} | ||
| done | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Copyright 2017 Serilog Contributors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| using Microsoft.Extensions.Logging; | ||
| using Serilog.Extensions.Logging; | ||
|
|
||
| namespace Serilog | ||
| { | ||
| /// <inherit /> | ||
| [ProviderAlias("Serilog")] | ||
| public class AliasedSerilogLoggerProvider : SerilogLoggerProvider | ||
| { | ||
| /// <inherit /> | ||
| public AliasedSerilogLoggerProvider(ILogger logger = null, bool dispose = false) | ||
| : base(logger, dispose) | ||
| { | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
There was a problem hiding this comment. New project containing only single file? There was a problem hiding this comment. @Cheesebaron If you want to get rid of internal static class ProviderAliasUtilities
{
private const string AliasAttibuteTypeFullName = "Microsoft.Extensions.Logging.ProviderAliasAttribute";
internal static string GetAlias(Type providerType)
{
foreach (CustomAttributeData attributeData in CustomAttributeData.GetCustomAttributes(providerType))
{
if (attributeData.AttributeType.FullName == AliasAttibuteTypeFullName)
{
foreach (CustomAttributeTypedArgument arg in attributeData.ConstructorArguments)
{
Debug.Assert(arg.ArgumentType == typeof(string));
return arg.Value?.ToString();
}
}
}
return null;
}
}😉 I will not tell you exactly why they did that, but since they did it, then the reason was and why not use such a opportunity? |
||
|
|
||
| <PropertyGroup> | ||
| <Description>Low-level Serilog provider for Microsoft.Extensions.Logging</Description> | ||
| <VersionPrefix>3.0.2</VersionPrefix> | ||
| <Authors>Microsoft;Serilog Contributors</Authors> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <AssemblyName>Serilog.Extensions.Logging.Extensions</AssemblyName> | ||
| <AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile> | ||
| <SignAssembly>true</SignAssembly> | ||
| <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign> | ||
| <PackageId>Serilog.Extensions.Logging.Extensions</PackageId> | ||
| <PackageTags>serilog;Microsoft.Extensions.Logging</PackageTags> | ||
| <PackageIcon>serilog-extension-nuget.png</PackageIcon> | ||
| <PackageProjectUrl>https://github.com/serilog/serilog-extensions-logging</PackageProjectUrl> | ||
| <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression> | ||
| <RepositoryUrl>https://github.com/serilog/serilog-extensions-logging</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute> | ||
| <RootNamespace>Serilog</RootNamespace> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="..\..\assets\serilog-extension-nuget.png" Pack="true" PackagePath="" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\Serilog.Extensions.Logging\Serilog.Extensions.Logging.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project uses two-spaces indentation for other csprojs