Bump Serilog version dependency to support Unity and .netstandard 2.0+ #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great - thanks. You should also be able to get your use case working by adding an explicit dependency on Serilog to your CSPROJ. |
This was referenced May 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to use this library in the Unity game engine but it only supports .NET Standard 2.0 onwards and the latest version of Serilog.Extensions.Logging still depends on Serilog 2.8.0 which in turn depends on System.Collections.NonGeneric and this in turn only targets .NET Standard 1.3.
https://docs.unity3d.com/Manual/dotnetProfileSupport.html
Simply upgrading from 2.8.0 to 2.9.0 solves the problem.