Skip to content

Commit 0332426

Browse files
committed
fix: Import declaration conflicts with local declaration
resolves aws#232 Typescript 3.7 does a better job identifying declaration conflicts and so identifies the conflite between the type and the class import of the same name. e.g. `WebCryptoEncryptionMaterial` is defined as a type and imported. When aws#148 was the referance to the return type can go directly to the needed Material (WebCrypto or Node).
1 parent 8f11f6a commit 0332426

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

modules/material-management-browser/src/browser_cryptographic_materials_manager.ts

-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import {
1717
WebCryptoMaterialsManager, EncryptionRequest, // eslint-disable-line no-unused-vars
1818
DecryptionRequest, EncryptionContext, // eslint-disable-line no-unused-vars
19-
EncryptionMaterial, DecryptionMaterial, // eslint-disable-line no-unused-vars
2019
WebCryptoAlgorithmSuite, WebCryptoEncryptionMaterial,
2120
WebCryptoDecryptionMaterial, SignatureKey, needs, readOnlyProperty,
2221
VerificationKey, AlgorithmSuiteIdentifier, immutableBaseClass,
@@ -29,8 +28,6 @@ import { fromBase64, toBase64 } from '@aws-sdk/util-base64-browser'
2928

3029
export type WebCryptoEncryptionRequest = EncryptionRequest<WebCryptoAlgorithmSuite>
3130
export type WebCryptoDecryptionRequest = DecryptionRequest<WebCryptoAlgorithmSuite>
32-
export type WebCryptoEncryptionMaterial = EncryptionMaterial<WebCryptoAlgorithmSuite>
33-
export type WebCryptoDecryptionMaterial = DecryptionMaterial<WebCryptoAlgorithmSuite>
3431
export type WebCryptoGetEncryptionMaterials = GetEncryptionMaterials<WebCryptoAlgorithmSuite>
3532
export type WebCryptoGetDecryptMaterials = GetDecryptMaterials<WebCryptoAlgorithmSuite>
3633

modules/material-management-node/src/node_cryptographic_materials_manager.ts

-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
import {
1717
NodeMaterialsManager, EncryptionRequest, DecryptionRequest, EncryptionContext, // eslint-disable-line no-unused-vars
18-
EncryptionMaterial, DecryptionMaterial, // eslint-disable-line no-unused-vars
1918
NodeAlgorithmSuite, NodeEncryptionMaterial, NodeDecryptionMaterial, SignatureKey,
2019
needs, VerificationKey, AlgorithmSuiteIdentifier,
2120
immutableClass, readOnlyProperty, KeyringNode,
@@ -28,8 +27,6 @@ import { createECDH } from 'crypto'
2827

2928
export type NodeEncryptionRequest = EncryptionRequest<NodeAlgorithmSuite>
3029
export type NodeDecryptionRequest = DecryptionRequest<NodeAlgorithmSuite>
31-
export type NodeEncryptionMaterial = EncryptionMaterial<NodeAlgorithmSuite>
32-
export type NodeDecryptionMaterial = DecryptionMaterial<NodeAlgorithmSuite>
3330
export type NodeGetEncryptionMaterials = GetEncryptionMaterials<NodeAlgorithmSuite>
3431
export type NodeGetDecryptMaterials = GetDecryptMaterials<NodeAlgorithmSuite>
3532

0 commit comments

Comments
 (0)