-
Notifications
You must be signed in to change notification settings - Fork 63
Compile errors of user of @aws-crypto/material-management with TypeScript 3.7.2 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Changing NodeJS to 10.16 doesn't change things. |
Thanks for the report! |
seebees
added a commit
to seebees/aws-encryption-sdk-javascript
that referenced
this issue
Nov 6, 2019
resolves aws#232 Typescript 3.7 does a better job identifying declaration conflicts and so identifies the conflite between the type and the class import of the same name. e.g. `WebCryptoEncryptionMaterial` is defined as a type and imported. When aws#148 was the referance to the return type can go directly to the needed Material (WebCrypto or Node).
seebees
added a commit
to seebees/aws-encryption-sdk-javascript
that referenced
this issue
Nov 6, 2019
resolves aws#232 Typescript 3.7 does a better job identifying declaration conflicts and so identifies the conflict between the type and the class import of the same name. e.g. `WebCryptoEncryptionMaterial` is defined as a type and imported. When aws#148 was the reference to the return type can go directly to the needed Material (WebCrypto or Node).
seebees
added a commit
to seebees/aws-encryption-sdk-javascript
that referenced
this issue
Nov 6, 2019
resolves aws#232 Typescript 3.7 does a better job identifying declaration conflicts and so identifies the conflict between the type and the class import of the same name. e.g. `WebCryptoEncryptionMaterial` is defined as a type and imported. When aws#148 was written the reference to the return type should have gone directly to the needed Material (WebCrypto or Node).
1 task
seebees
added a commit
that referenced
this issue
Nov 7, 2019
resolves #232 Typescript 3.7 does a better job identifying declaration conflicts and so identifies the conflict between the type and the class import of the same name. e.g. `WebCryptoEncryptionMaterial` is defined as a type and imported. When #148 was written the reference to the return type should have gone directly to the needed Material (WebCrypto or Node).
If I may ask, what is the rough timeline for a release of the SDK with the fix for that problem? |
@ankon Released to npm :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With @aws-crypto/client-node 1.0.1, TypeScript 3.7.2, on NodeJS 12.13.0 I'm getting this error when compiling our own sources:
tsconfig.json
:tsconfig.es6.json
:tsconfig.base.json
:(https://github.com/Collaborne/tsconfig-collaborne/blob/master/tsconfig.json has "tsconfig-collaborne")
The text was updated successfully, but these errors were encountered: