Simplified usage of will()

[fabian]

Enable use of will('something') instead of will($this->returnValue('something'))

[makasim]

great addition. It would make will method usage convention compatible with with method one.

<?php
$mock->with($this->equalsTo($foo));
$mock->will($this->returnValue($foo));

// and

$mock->with($foo);
$mock->will($foo);

👍

[whatthejeff]

I've actually thought about this a lot in the past. What I think makes more sense is to replace $mock->will($this->returnValue($foo)); with $mock->willReturn($foo); since the point of this interface is to be more-or-less readable/fluent.

[whatthejeff]

I'd also like to see ->expects($this->any()) made optional so we could do something like:

$mock->method('doSomething')->willReturn('something');

[zwilias]

I like @whatthejeff's proposal, makes a lot of sense to me.

[ciaranmcnulty]

I've opened a separate PR (#146) for @whatthejeff's second proposal about making expects() optional - it makes very good sense to me.

[ciaranmcnulty]

On this subject it would be nice to allow both will('foo') and willReturn('foo') as aliases.

The former fits with the existing pattern for with(), the latter is more verbose and clear. It would be nice to give authors the option.

[ciaranmcnulty]

Needs a comment about what happens with a scalar

[fabian]

Added below.

[whatthejeff]

These might be nice too:

$stub->method('doSomething')->willReturnMap(...);
$stub->method('doSomething')->willReturnArgument(...);
$stub->method('doSomething')->willReturnCallback(...);
$stub->method('doSomething')->willReturnSelf(...);
$stub->method('doSomething')->willReturnOnConsecutiveCalls(...);
$stub->method('doSomething')->willThrowException(...);

[ciaranmcnulty]

I like @whatthejeff's suggestions, don't think they block merging this though? Then either @fabian or someone else could do a separate PR for the longer versions.

[sebastianbergmann]

I prefer the syntax proposed by @whatthejeff.

[ciaranmcnulty]

@fabian Do you want to implement these suggestions? Otherwise I can?

[fabian]

Yes, already started, didn't find the time to finish though: https://github.com/fabian/phpunit-mock-objects/commits/willReturn

Would love to get some feedback before I create a PR.

[whatthejeff]

Closing in favor of #147.