Skip to content

[SERF-1700] Upgrade go version to 1.18.5 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 8, 2022
Merged

[SERF-1700] Upgrade go version to 1.18.5 #54

merged 6 commits into from
Aug 8, 2022

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Aug 8, 2022 •
edited
Loading

Description

As Go version 1.19 is released we update the Go version to 1.18 to stay in the supported versions loop.

In this PR we:

  • Updated the go version in Dockerfile
  • Upgrade golangci-lint to v1.47.3
  • Updated version in go.mod file
  • Ran go mod tidy against the source code
  • Ran go fix -tags ignore github.com/scribd/go-sdk/cmd/mage and go fix -tags mage

NOTE: Upgrade golangci-lint to version v1.47.3 is needed to support go1.18. The latest version contains a bug, that is why we stick to the previous version.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep requested a review from a team as a code owner August 8, 2022 14:01
@Neurostep Neurostep requested a review from fotos August 8, 2022 14:01
terranisu
terranisu previously approved these changes Aug 8, 2022
View reviewed changes
@terranisu
Copy link
Member

terranisu commented Aug 8, 2022 •
edited
Loading

The linter check fails though

@Neurostep Neurostep force-pushed the maksimt/SERF-1700/upgrade-go-version branch from 7f49a9d to e563a9d Compare August 8, 2022 14:26
@Neurostep Neurostep requested a review from terranisu August 8, 2022 14:35
terranisu
terranisu approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Neurostep Neurostep requested a review from laynax August 8, 2022 14:45
fotos
fotos approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@fotos fotos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 1️⃣ . 1️⃣ 8️⃣ 🚀

@Neurostep Neurostep merged commit 4dc39fb into main Aug 8, 2022
@Neurostep Neurostep deleted the maksimt/SERF-1700/upgrade-go-version branch August 8, 2022 15:34
@fotos fotos mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fotos fotos fotos approved these changes

@terranisu terranisu terranisu approved these changes

@laynax laynax laynax approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neurostep @terranisu @fotos @laynax