-
Notifications
You must be signed in to change notification settings - Fork 159
add sbt 1.0.0-RC3 support, fixes #216 #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scalajs test fails for 0.13 for some reason. Both on CI and my local machine |
Also, it's not possible to run scalajs tests for 1.0.0-RC2 until scala-js/scala-js#3075 released as scalajs doesn't support sbt 1.0.0-RC2 yet |
project/build.properties
Outdated
@@ -1 +1 @@ | |||
sbt.version=0.13.13 | |||
sbt.version=0.13.16-RC1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt 0.13.16-RC1 allows to make cross building without plugin. Not sure we should merge it before 0.13.16 final release
This one is fixed |
All tests passed at CI. Also upgraded sbt versions to 0.13.16 and 1.0.0-RC3 respectively |
Hi @rockjam Thank you for your PR. I've tested it. The code can be slightly simplified. Could you change the line:
to
and remove |
@gslowikowski Done! Thanks for advice |
A release for sbt 1.0.x would be much appreciated! There are many builds who use this. |
This PR adds support for sbt 1.0.0-RC2 which is close to upcoming 1.0.0 release