-
Notifications
You must be signed in to change notification settings - Fork 159
Any chance at a way to combine sub-project reports into one? #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi Age ! There was a request for multi-project reports, https://github.com/mtkopone/sbt-scct/blob/master/src/main/scala/ScctPlugin.scala#L96 I think the ticket was deleted by error |
Then please consider this ticket its replacement. Multi-project merged reports would be a very welcome addition! If you guys don't have time, I'll try to improve my SBT plugin skills so I can produce a pull request but it might take a while ;) |
I'm going to get it finished before scaladays as I want to release version 1.0 prior to that. |
Awesome, thanks! |
Any update on this feature yet? Scaladays is over ;P Just curious, I could definitely use the merged reports for a multi-module build. (great plugin btw) |
+1 for this feature. |
Current status is the merging works, I just need to update the sbt plugin On 23 July 2014 09:29, Yann Moisan [email protected] wrote:
|
Nice! I will be glad to test it out on our multi-module build once it is ready |
I am really looking forward to this. Any news? Also if it's not completly ready yet maybe you could still provide it in a branch so that we can help and give feedback. |
+1 for this. |
Hi there? Any updates on this issue? |
+1 for Multi Module aggregated report. |
+1 |
+1 for this - really need multi-project support! @sksamuel any chance we can see code so I can build myself? |
The code is pushed. If you build from master, then it should/may work, but I've not tested it much yet. |
Thanks! Really great work, thanks! |
I'm hoping to release 1.0 final next few days. Just need to write
|
@massenz @sortega @nightwolfzor @fractal @agemooij @diwalak @nlochschmidt Multiproject support is now in beta3. You need to now run with Any questions please ask, this is a big release, so perhaps some new bugs. |
I've been trying to use 1.0.0.BETA3 - it apparently gets downloaded and installed (I can see it inside
And I can see the new
However, SBT gets angry at me with:
and, obviously, if I remove the Thanks! |
BTW - where is the "aggregated" report placed?
But when I look in the top-level project, the Running a |
The aggregate report overwrites the old one, but you've found a bug. I'll As for the keys, you can do I don't know why its not "auto importing" like it should. On 19 November 2014 08:03, Marco Massenzio [email protected] wrote:
|
FYI, SBT autoImports currently only work for .sbt files using the old syntax. Both .scala builds en .sbt builds using the new syntax (defining the project directly as a val) will need to import the autoImport object directly. I've tried various ways of working around this in my own plugin but so far nothing better has turned up, just "double import" warnings from the compiler. |
lol so auto import doesn't really work? Typical sbt. Thanks for the info. I'll rename it back to keys then so its clear that it won't be auto On 19 November 2014 09:53, Age Mooij [email protected] wrote:
|
I'm sure the plan is that eventually it will work. It just doesn't yet. |
I can update the keys in another release, right now I think it would be On 19 November 2014 10:45, Age Mooij [email protected] wrote:
|
I updated my build and ran |
What version of sbt? All I can find is this: On 20 November 2014 10:03, Yann Simon [email protected] wrote:
|
I tried sbt 0.13.5, 0.13.6 and 0.13.7. I have play as dependency. |
I do indeed have a large xml file containing information from multiple sub projects in the Looking forward to see the rendered report |
Yep that's going in, then that's release 1.0 going out. On 20 November 2014 11:14, Age Mooij [email protected] wrote:
|
Release 1.0.0 is out now with readme updated. |
[side note:
end side-note] Good news and bad news :)
unfortunately, at least in my case, it's not what it's supposed to be. Looking at the XML it looks as if that's the broken one. |
For info, I fixed my problem with Now the code coverage is running, but I have the same problem as @massenz : the aggregated report contains much less data than the individual ones. |
Do any of you have a sample project that re-creates this aggregated report On 26 November 2014 at 09:42, Yann Simon [email protected] wrote:
|
I do not have any, but maybe you could use the project from @massenz ? |
Ah yes didn't see that. |
Awfully sorry, guys, I realize that I never posted here (but have somewhere else, I'm sure). I'm not sure what the "fix" proposed by @yanns does, but I can confirm I did have an sbt import issue at first, which I fixed by clearing the As you can see in my sentinel the coverage is now correctly reported at 84% (see also the coveralls report). The only thing that mars this landscape is the broken sbt-coveralls plugin. |
I'm sorry but I'm not having a lot of luck with the 1.0.0 version. It's a client project so I can't put code online but it has about 10 sub-projects. Clearing the Ivy cache somehow made it even worse since running
Any ideas? Stacktrace details:
|
Try 'sbt clean test' first Only after all your tests pass, you can run coverage. sent from my Nexus
|
Interesting. It was probably some fluke with a weird project state that caused the exceptions, although it might be a good idea to make sure you don't produce hard failures with nullpointer exceptions when files are not where you expect them to be. As of this morning the problem is back to the one mentioned in issue #64, i.e. the results (single and aggregated) are incomplete and different every run. |
I'm still struggling to find out what is causing this, but I am On 27 November 2014 at 09:50, Age Mooij [email protected] wrote:
|
Your stack trace was from this line val index = IOUtils.readStreamAsString(getClass.getResourceAsStream("/scoverage/index.html")) Which can't/shouldn't throw an NPE as that resource is in the On 27 November 2014 at 09:53, Stephen Samuel (Sam) [email protected] wrote:
|
@agemooij I might have asked this before but can you confirm, when you run coverage and the aggregated files change on each run - do the xml files give different results just by running the normal coverage without aggregation? |
Yes they do, the coverage numbers are different every run, although from some experimentation they seem to converge on a specific outcome after about 3-5 runs (without cleaning in between). Cleaning the build starts the process of convergence again and the converged coverage numbers are also different each time they converge. In other words, the numbers are very unreliable. |
The actual coverage AST stuff is sound, this is something to do with the On 27 November 2014 at 11:08, Age Mooij [email protected] wrote:
|
Version 1.0.1 should address this issue. |
I confirm the issue is fixed. |
On the HTML report, the links to the sources are broken because the sources are copied in the wrong location: |
I can verify that version 1.0.1 seems to have fixed both the missing aggregate report as also the weird and conflicting results. I can also confirm that the aggregation task seems to have copied the entire path from the filesystem root all the way down to the module sources into the |
1.0.1 fixes the aggregate issue. |
I have a maven project and not sbt, how do i get a aggregated scoverage report for my project that has multiple modules. I see that each individual module creates a scoverage.xml in its target directory. Currently from top-level i run it as mvn clean test install scoverage:report -Dmaven.test.failure.ignore=true |
I was also wondering if there is any chance that the Maven plugin get updated with the aggregate feature, too? -- Update: ok forget my question, found it myself: true |
I've just started using the sbt-scoverage plugin and my first impression is that it is much better than jacoco or scct. Great work!
My current project has multiple sub-projects and I was wondering whether you see a way to combine the outputs of all the individual tests into one big report across all projects. Do you think this is possible?
I'm more than willing to help add this feature. At this point I'm just not sure how hard/easy it would be and where to start.
Again, great work!
Age
The text was updated successfully, but these errors were encountered: