Skip to content

Fix darwin/arm64/cp39 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix darwin/arm64/cp39 #24

wants to merge 1 commit into from

Conversation

mmac-m3a
Copy link

This should fix issue #23

@mmac-m3a
Fix darwin/arm64/cp39
6802219 
This should fix issue #23
@mmac-m3a mmac-m3a mentioned this pull request Aug 17, 2021
Closed
3 tasks
rgommers
rgommers reviewed Aug 18, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmac-m3a, yes we should update this. numpy 1.21.0 is the first version with both universal2 and arm64 wheels, so we should use that version rather than 1.21.2.

I now see that I already submitted a PR for that (gh-22), it just did not get merged. So I'll do that now. I'll then close this PR.

@rgommers
Copy link
Member

I'll comment on the issue you opened about a new release with this fix. Thanks again.

@rgommers rgommers closed this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmac-m3a @rgommers