Skip to content

oldest-supported-numpy build fails on Apple Silicon #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kbourgoin opened this issue May 27, 2021 · 8 comments · Fixed by #20
Closed

oldest-supported-numpy build fails on Apple Silicon #19

kbourgoin opened this issue May 27, 2021 · 8 comments · Fixed by #20

Comments

@kbourgoin
Copy link
Contributor

kbourgoin commented May 27, 2021 •
edited
Loading

I'm trying to install a project which relies on oldest-supported-numpy and it won't build because it's trying to install numpy==1.19.3 and it looks to me like numpy doesn't build on arm64 until 1.20.0 using python 3.9.5.

I'm not super familiar with the numpy build system, so I may be wrong about needing >=1.20.0. It's how it works on my system right now and the failures are a bunch of clang errors I can't debug.
@kbourgoin kbourgoin changed the title Numpy build fails on Apple Silicon oldest-supported-numpy build fails on Apple Silicon May 27, 2021
@kbourgoin kbourgoin mentioned this issue May 27, 2021
Merged
@rgommers
Copy link
Member

Thanks for the report @kbourgoin

I'm not super familiar with the numpy build system, so I may be wrong about needing >=1.20.0. It's how it works on my system right now and the failures are a bunch of clang errors I can't debug.

Yes indeed, at least 1.20.0. It's possible that there are fixes in 1.20.1-1.20.3 that are needed as well. Right now there are no numpy wheels for macOS M1 yet (either arm64 or universal2), so it's not easy to figure out what the correct lower limit is. Once those wheels show up (I think we'll have them for 1.21.0) then that should be the lower limit.

@charris
Copy link
Member

charris commented May 27, 2021

There is a universal2 wheel for NumPy 1.21.0rc1.

@kbourgoin
Copy link
Contributor Author

I'm not very familiar with numpy builds, but 1.20.0 builds without issue for me. Do we need to wait for those wheels to be published before the proposed fix can be merged? I only pip install oldest-supported-numpy as part of a dependency, so I'm a bit out of my depth here.

@rgommers
Copy link
Member

I'm not very familiar with numpy builds, but 1.20.0 builds without issue for me. Do we need to wait for those wheels to be published before the proposed fix can be merged?

No we don't, we can merge it now. But once 1.21.0 arrives in a few weeks, I'd like to bump the version number. So if you depend on the reproducibility of 1.20.0, you should probably use oldest-supported-numpy==0.9.

@kbourgoin
Copy link
Contributor Author

@rgommers any chance of this getting merged soon?

@rgommers
Copy link
Member

rgommers commented Jun 6, 2021

Yes, let's get that fix in. The next step is releasing it - let's do that straight away too, otherwise it's still not useful.

@rgommers
Copy link
Member

rgommers commented Jun 6, 2021

Okay, v0.9 is on PyPI now.

@kbourgoin
Copy link
Contributor Author

Thank you!

rgommers added a commit to rgommers/oldest-supported-numpy that referenced this issue Jun 25, 2021
@rgommers
Update macOS ARM64 requirement to 1.21.0
4d5594a 
This is the first NumPy version with universal2 wheels, and 1.21.0
was just released so we can do the version bump.

This is a follow-up to scipygh-19 and scipygh-20
@rgommers rgommers mentioned this issue Jun 25, 2021
Merged
@sradc sradc mentioned this issue Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

macOS arm64 requires numpy 1.20.0 or above kbourgoin/oldest-supported-numpy
3 participants
@charris @rgommers @kbourgoin