Skip to content

macOS Python 3 wheel missing due to broken travis build! #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henryiii opened this issue Aug 21, 2020 · 9 comments
Closed

macOS Python 3 wheel missing due to broken travis build! #112

henryiii opened this issue Aug 21, 2020 · 9 comments

Comments

@henryiii
Copy link
Contributor

henryiii commented Aug 21, 2020

Can someone (@jcfr, possibly?) please restart the Travis CI build? It broke, causing macOS wheels for CMake 3.18.2 Python 3 to not upload, killing downstream projects who try to build with CMake's pip package (since it tried to build with the tarball).

In the future, I have found GitHub Actions / Azure to be much more reliable than Travis for macOS. ;)

[scikit-ci] Executing: python ../addons/travis/install_pyenv.py
195dyld: Library not loaded: /usr/local/opt/gettext/lib/libintl.8.dylib
196  Referenced from: /Users/travis/.pyenv/versions/3.7.4/bin/python
197  Reason: Incompatible library version: python requires version 11.0.0 or later, but libintl.8.dylib provides version 10.0.0
198/var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/tmpqIYbnV.sh: line 2:  2975 Abort trap: 6           python ../addons/travis/install_pyenv.py
199
200A command failed while executing BEFORE_INSTALL step.
201  Return code:
202    134
203  Command:
204    python ../addons/travis/install_pyenv.py
205  Working directory:
206    /Users/travis/build/scikit-build/cmake-python-distributions
207
208Please see above for more information.
209
210The command "ci install" failed and exited with 1 during .

CC @jpivarski, who discovered this due to AwkwardArray's CI failing.

@jcfr
Copy link
Contributor

jcfr commented Aug 21, 2020

Can someone please restart the Travis CI build?

Few days ago, I addressed similar issue for a different project.
See https://github.com/CastXML/CastXML-python-distributions/blob/e03b460b03032d00e00fcca27ae10548d22999a5/.travis.yml#L39-L45

I have found GitHub Actions

Agreed. I started experimenting with it . See https://github.com/jcfr/ci-sandbox/commits/add-github-workflow

Once I have a reliable and working setup, I will transition cmake-python-distribution, ninja-python-distribution, ... I guess we could only use it for macOS now.

@henryiii
Copy link
Contributor Author

henryiii commented Aug 21, 2020

Also, cibuildwheel is a great way to build these without being too dependent on which CI you are using; matplotlib just started using it. Also see the GHA sections here: https://scikit-hep.org/developer

@henryiii
Copy link
Contributor Author

Hopefully this gets uploaded very soon, but in the meantime, is there a way to put something like "--only-binary cmake" into a pyproject.toml file?

@jcfr
Copy link
Contributor

jcfr commented Aug 21, 2020

After merging the PR, I will release 3.18.2.post1

jcfr added a commit that referenced this issue Aug 21, 2020
@henryiii
Copy link
Contributor Author

henryiii commented Aug 21, 2020

If ignore duplicates is on for twine, you technically can just release 3.18.2 again, everything except macOS Py 3 will be ignored (since there are no code changes). (Depends slightly on how you trigger the upload, however).

@jcfr
Copy link
Contributor

jcfr commented Aug 24, 2020

If ignore duplicates is on for twine, you technically can just release 3.18.2 again

Great idea. I will add the --skip-existing flag then.

@jcfr
Copy link
Contributor

jcfr commented Aug 24, 2020

Turns out we already pass that option. Since the release process is triggered when a tag is pushed, I will just push a new tag.

Also true I could delete the previous tag ... and push again

@jcfr
Copy link
Contributor

jcfr commented Aug 24, 2020

Release 3.18.2.post1 in progress

@jcfr
Copy link
Contributor

jcfr commented Aug 25, 2020

Closing. Release packages available at https://pypi.org/project/cmake/#files

@jcfr jcfr closed this as completed Aug 25, 2020
jcfr added a commit to scikit-build/ninja-python-distributions that referenced this issue Sep 10, 2020
Adapted from the following commits:

* ci: Update travis to fix "libintl" loading error
  See scikit-build/cmake-python-distributions@28b0d4b

* ci: travis update python version from 3.7.4 to 3.7.8
  See scikit-build/cmake-python-distributions@dd85efd

* ci: Tweak cache and before_cache steps
  See scikit-build/cmake-python-distributions@6ec58d7

See scikit-build/cmake-python-distributions#112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants